Tweaks « Cumps.be

Modified MVC AccountController for Preview 5

Gepost op 2008.09.12 | Reacties (4) | ASP.NET MVC, C#, Technologie, Tweaks

I just downloaded the ASP.NET MVC Preview 5 bits from Codeplex and started on my first experiment.

One of the first things I did was to modify the default AccountController to use the new Form Posting and Form Validation features of the Preview 5, somebody probably overlooked updating those

If anyone else wants the reworked code, feel free to copy paste.

Note this was something done during lunch break in a hurry, it seems to all work logically, but it's possible I'll have to tune it a bit later on.

Controller:

PLAIN TEXT

C#:

[HandleError]
[OutputCache(Location = OutputCacheLocation.None)]
public class AccountController : Controller
{
public AccountController()
: this(null, null)
{
}
public AccountController(IFormsAuthentication formsAuth, MembershipProvider provider)
{
FormsAuth = formsAuth ?? new FormsAuthenticationWrapper();
Provider = provider ?? Membership.Provider;
}
public IFormsAuthentication FormsAuth
{
get;
private set;
}
public MembershipProvider Provider
{
get;
private set;
}
[Authorize]
[AcceptVerbs("GET")]
public ActionResult ChangePassword()
{
ViewData["Title"] = "Change Password";
ViewData["PasswordLength"] = Provider.MinRequiredPasswordLength;
return View();
}
[Authorize]
[AcceptVerbs("POST")]
public ActionResult ChangePassword(string currentPassword, string newPassword, string confirmPassword)
{
// Basic parameter validation
if (String.IsNullOrEmpty(currentPassword))
{
ViewData.ModelState.AddModelError("currentPassword", currentPassword, "You must specify a current password.");
}
if (newPassword == null || newPassword.Length <Provider.MinRequiredPasswordLength)
{
ViewData.ModelState.AddModelError("newPassword", newPassword, String.Format(CultureInfo.InvariantCulture,
"You must specify a new password of {0} or more characters.",
Provider.MinRequiredPasswordLength));
}
if (!String.Equals(newPassword, confirmPassword, StringComparison.Ordinal))
{
ViewData.ModelState.AddModelError("newPassword", newPassword, "The new password and confirmation password do not match.");
}
if (ViewData.ModelState.IsValid)
{
// Attempt to change password
MembershipUser currentUser = Provider.GetUser(User.Identity.Name, true /* userIsOnline */);
bool changeSuccessful = false;
try
{
changeSuccessful = currentUser.ChangePassword(currentPassword, newPassword);
}
catch
{
// An exception is thrown if the new password does not meet the provider's requirements
}
if (changeSuccessful)
{
return RedirectToAction("ChangePasswordSuccess");
}
else
{
ViewData.ModelState.AddModelError("password", currentPassword, "The current password is incorrect or the new password is invalid.");
}
}
// If we got this far, something failed, redisplay form
ViewData["Title"] = "Change Password";
ViewData["PasswordLength"] = Provider.MinRequiredPasswordLength;
return View();
}
public ActionResult ChangePasswordSuccess()
{
ViewData["Title"] = "Change Password";
return View();
}
[AcceptVerbs("GET")]
public ActionResult Login()
{
ViewData["Title"] = "Login";
ViewData["CurrentPage"] = "login";
return View();
}
[AcceptVerbs("POST")]
public ActionResult Login(string username, string password, bool? rememberMe)
{
// Basic parameter validation
if (String.IsNullOrEmpty(username))
{
ViewData.ModelState.AddModelError("username", username, "You must specify a username.");
}
if (ViewData.ModelState.IsValid)
{
// Attempt to login
bool loginSuccessful = Provider.ValidateUser(username, password);
if (loginSuccessful)
{
FormsAuth.SetAuthCookie(username, rememberMe ?? false);
return RedirectToAction("Index", "Home");
}
else
{
ViewData.ModelState.AddModelError("*", username, "The username or password provided is incorrect.");
}
}
// If we got this far, something failed, redisplay form
ViewData["Title"] = "Login";
ViewData["CurrentPage"] = "login";
ViewData["username"] = username;
return View();
}
public ActionResult Logout()
{
FormsAuth.SignOut();
return RedirectToAction("Index", "Home");
}
protected override void OnActionExecuting(ActionExecutingContext filterContext)
{
if (filterContext.HttpContext.User.Identity is WindowsIdentity)
{
throw new InvalidOperationException("Windows authentication is not supported.");
}
}
[AcceptVerbs("GET")]
public ActionResult Register()
{
ViewData["Title"] = "Register";
ViewData["PasswordLength"] = Provider.MinRequiredPasswordLength;
return View();
}
[AcceptVerbs("POST")]
public ActionResult Register(string username, string email, string password, string confirmPassword)
{
// Basic parameter validation
if (String.IsNullOrEmpty(username))
{
ViewData.ModelState.AddModelError("username", username, "You must specify a username.");
}
if (String.IsNullOrEmpty(email))
{
ViewData.ModelState.AddModelError("email", email, "You must specify an email address.");
}
if (password == null || password.Length <Provider.MinRequiredPasswordLength)
{
ViewData.ModelState.AddModelError("password", password, String.Format(CultureInfo.InvariantCulture,
"You must specify a password of {0} or more characters.",
Provider.MinRequiredPasswordLength));
}
if (!String.Equals(password, confirmPassword, StringComparison.Ordinal))
{
ViewData.ModelState.AddModelError("confirmPassword", confirmPassword, "The password and confirmation do not match.");
}
if (ViewData.ModelState.IsValid)
{
// Attempt to register the user
MembershipCreateStatus createStatus;
MembershipUser newUser = Provider.CreateUser(username, password, email, null, null, true, null, out createStatus);
if (newUser != null)
{
FormsAuth.SetAuthCookie(username, false /* createPersistentCookie */);
return RedirectToAction("Index", "Home");
}
else
{
ViewData.ModelState.AddModelError("*", username, ErrorCodeToString(createStatus));
}
}
// If we got this far, something failed, redisplay form
ViewData["Title"] = "Register";
ViewData["PasswordLength"] = Provider.MinRequiredPasswordLength;
ViewData["username"] = username;
ViewData["email"] = email;
return View();
}
public static string ErrorCodeToString(MembershipCreateStatus createStatus)
{
// See http://msdn.microsoft.com/en-us/library/system.web.security.membershipcreatestatus.aspx for
// a full list of status codes.
switch (createStatus)
{
case MembershipCreateStatus.DuplicateUserName:
return "Username already exists. Please enter a different user name.";
case MembershipCreateStatus.DuplicateEmail:
return "A username for that e-mail address already exists. Please enter a different e-mail address.";
case MembershipCreateStatus.InvalidPassword:
return "The password provided is invalid. Please enter a valid password value.";
case MembershipCreateStatus.InvalidEmail:
return "The e-mail address provided is invalid. Please check the value and try again.";
case MembershipCreateStatus.InvalidAnswer:
return "The password retrieval answer provided is invalid. Please check the value and try again.";
case MembershipCreateStatus.InvalidQuestion:
return "The password retrieval question provided is invalid. Please check the value and try again.";
case MembershipCreateStatus.InvalidUserName:
return "The user name provided is invalid. Please check the value and try again.";
case MembershipCreateStatus.ProviderError:
return "The authentication provider returned an error. Please verify your entry and try again. If the problem persists, please contact your system administrator.";
case MembershipCreateStatus.UserRejected:
return "The user creation request has been canceled. Please verify your entry and try again. If the problem persists, please contact your system administrator.";
default:
return "An unknown error occurred. Please verify your entry and try again. If the problem persists, please contact your system administrator.";
}
}
}
// The FormsAuthentication type is sealed and contains static members, so it is difficult to
// unit test code that calls its members. The interface and helper class below demonstrate
// how to create an abstract wrapper around such a type in order to make the AccountController
// code unit testable.
public interface IFormsAuthentication
{
void SetAuthCookie(string userName, bool createPersistentCookie);
void SignOut();
}
public class FormsAuthenticationWrapper : IFormsAuthentication
{
public void SetAuthCookie(string userName, bool createPersistentCookie)
{
FormsAuthentication.SetAuthCookie(userName, createPersistentCookie);
}
public void SignOut()
{
FormsAuthentication.SignOut();
}
}

PLAIN TEXT

ASP:

<%@ Page Language="C#" MasterPageFile="~/Views/Shared/Site.Master" AutoEventWireup="true" CodeBehind="Login.aspx.cs" Inherits="GuildSite.Views.Account.Login" %>
<asp:Content ID="loginContent" ContentPlaceHolderID="MainContent" runat="server">
<h2>Login</h2>
<p>
Please enter your username and password below. If you don't have an account,
please <%= Html.ActionLink("register", "Register") %>.
</p>
<%= Html.ValidationSummary()%>
<form method="post" action="<%= Html.AttributeEncode(Url.Action("Login")) %>">
<div class="form">
<table>
<tr>
<td>Username:</td>
<td><%= Html.TextBox("username") %></td>
</tr>
<tr>
<td>Password:</td>
<td><%= Html.Password("password") %></td>
</tr>
<tr>
<td></td>
<td><input type="checkbox" name="rememberMe" value="true" /> Remember me?</td>
</tr>
<tr>
<td></td>
<td><input type="submit" value="Login" /></td>
</tr>
</table>
</div>
</form>
</asp:Content>

PLAIN TEXT

ASP:

<%@ Page Language="C#" MasterPageFile="~/Views/Shared/Site.Master" AutoEventWireup="true" CodeBehind="Register.aspx.cs" Inherits="GuildSite.Views.Account.Register" %>
<asp:Content ID="registerContent" ContentPlaceHolderID="MainContent" runat="server">
<h2>Account Creation</h2>
<p>
Use the form below to create a new account.
</p>
<p>
Passwords are required to be a minimum of <%=Html.Encode(ViewData["PasswordLength"])%> characters in length.
</p>
<%= Html.ValidationSummary()%>
<form method="post" action="<%= Html.AttributeEncode(Url.Action("Register")) %>">
<div class="form">
<table>
<tr>
<td>Username:</td>
<td><%= Html.TextBox("username") %></td>
</tr>
<tr>
<td>Email:</td>
<td><%= Html.TextBox("email") %></td>
</tr>
<tr>
<td>Password:</td>
<td><%= Html.Password("password") %></td>
</tr>
<tr>
<td>Confirm password:</td>
<td><%= Html.Password("confirmPassword") %></td>
</tr>
<tr>
<td></td>
<td><input type="submit" value="Register" /></td>
</tr>
</table>
</div>
</form>
</asp:Content>

Wordpress 2.6 Upgrade – Fix Missing Categories

Gepost op 2008.07.17 | Reacties (202) | Technologie, Tweaks

Apparently I'm not the only one having problems with the categories after a Wordpress 2.6 upgrade.

So, time to give something back to the Wordpress community, some screenshots on how I fixed it.

First of all, I upgraded from 2.2.3 to 2.6, it's possible this solution will work for you, but I don't make any promises.

I started by going to phpMyAdmin and having a look at the wp_term_taxonomy table, and noticed all the descriptions where missing.

When I took a look at the backup file I made, more specifically, the wp_categories piece, I noticed the counts and ids matched up.

Empty Descriptions

I then manually edited each record, just hit the pencil icon, and filled in all my descriptions again. If you know some SQL you could do this faster, but anyway, everyone can do it manually

Corrected Descriptions

After I've done this, I visited my admin section and noticed the Descriptions were filled in again. But there was no Name, and all my posts still had empty categories linked to them.

To fix this, visit http://your-site/wp-admin/categories.php?action=edit&cat_ID=1 where 1 is the category id to edit. Fill in a Name and a Slug, the url name for your category, and save it.

Repeat this process for all your categories, until they all have a Name again.

Edit Names and Slugs

And that's it! Categories fixed, posts linked, category urls working again.

All Fixed

Good luck!

Wordpress 2.6 Upgrade – Categories Missing

Gepost op 2008.07.16 | Reacties (23) | Technologie, Tweaks

A moment ago, I decided to upgrade to the latest Wordpress version, I was running a bit behind on 2.2.3

The upgrade went quite smooth, all my plugins still work. But suddenly all my categories became empty strings. And the /tags/ urls didn't work anymore either.

After looking around a bit, I noticed my categories were stored in the wp_term_taxonomy table, with empty descriptions. Thankfully I had a backup and manually entered the descriptions for all of them.

At this point, their names showed up in the admin section again, but the post weren't linked to them yet, neither did the /tags/ work.

A little more looking around, and I figured out to access categories.php?action=edit&cat_ID=20 for each category, where I had to enter the category name and category slug.

For some reason, each category's slug was suddenly named -2-2-2-2-2-2-2-2-2-2-2-2-2, with increasing -2 per category.

After doing all that, my /tags/ work again, and my posts seem to be linked again

If you notice anything broken, please comment to let me know!

Efficient Compound Index Usage

Gepost op 2007.09.20 | Reacties (5) | Performance, SQL Server, Technologie, Tweaks

Today I was made aware by Filip, a colleague of mine, about the importance of columns used in a where clause with a compound index. I decided to investigate this a bit more in detail, with proper profiling and comparisons on a large data set.

I created a test table, DemoTable, which looks as follows:

PLAIN TEXT

SQL:

ColumnA varchar(6)
ColumnB int
ColumnC int
ColumnD varchar(3)
..30 more COLUMNS..

The primary key consists out of ColumnA, ColumnB and ColumnC. Which implicitly means it acts as a compound index.

There are about 6.5 million records in the table.

Full Primary Key Lookup

The most obvious query to get data from this table is a simple select, using all values of the primary key, as follows:

PLAIN TEXT

SQL:

SELECT *
FROM DemoTable
WHERE ColumnA = 'DCU'
AND ColumnB = 1
AND ColumnC = 1

Taking a look at the query plan, this does exactly what most people expect it to do, it uses a very efficient Index Seek to pick out the matching record.

A, B, C

Partial Primary Key Lookup

A variation to the above query, is the following one, using only part of the primary key.

PLAIN TEXT

SQL:

SELECT *
FROM DemoTable
WHERE ColumnA = 'DCU'
AND ColumnB = 1

The query plan shows us that this query is also very efficient, since it can make full use of the index to get the results back.

A, B

Out of curiosity and to be thorough, I also checked the results of the following query:

PLAIN TEXT

SQL:

SELECT *
FROM DemoTable
WHERE ColumnA = 'DCU'

Same story, our index is ordered on ColumnA, ColumnB and ColumnC, so it can easily use a binary search on it and give back all results for ColumnA.

The fun stuff begins when we don't just remove columns from the where clause in the same order the index is created, for example this query:

PLAIN TEXT

SQL:

SELECT *
FROM DemoTable
WHERE ColumnA = 'DCU'
AND ColumnC = 1

SQL Server will first use an efficient index seek to get all results for the correct ColumnA, since the index is ordered by ColumnA first, and will then search in the remaining results for the correct ColumnC.

In the query plan, you can identify this as the Predicate, which displays ColumnC. In the end, this is still an efficient query, but if the majority of your queries would be filtering on ColumnA and ColumnC, it would be a good idea to change your column order to ColumnA, ColumnC, ColumnB in the index. This way, the overall efficiency of your index would increase.

A, C

Another variation of a partial key lookup is the following query:

PLAIN TEXT

SQL:

SELECT *
FROM DemoTable
WHERE ColumnB = 1
AND ColumnC = 1

And it's at this point you can say goodbye to performance. To get the requested results, SQL Server will do a full scan on every value in your index to find matches. Making it go over 6.5 million pieces of data in my example.

If lots of your queries would be like this, I'd suggest to consider changing the column order, or add an index on ColumnB and ColumnC. Keep in mind that adding indexes has a drawback on performance of INSERTs and DELETEs, it's up to each project to define this delicate balance.

B, C

Partial Primary Key Lookup Sorted

Another case I wanted to check, was how SQL Server handles ORDER BY clauses with regards to columns in an index.

I started simple by doing:

PLAIN TEXT

SQL:

SELECT *
FROM DemoTable
WHERE ColumnA = 'DCU'
AND ColumnB = 1
ORDER BY ColumnC

As expected, SQL Server simply does an index scan for ColumnA and ColumnB and returns the results, since they are already ordered by ColumnC in the index. As efficient as possible.

A, B Order C

A small variation to this query leaves out the first column of the index, resulting in:

PLAIN TEXT

SQL:

SELECT *
FROM DemoTable
WHERE ColumnB = 1
ORDER BY ColumnC

Again, since our WHERE clause is not using the columns in the order of the index, we are invoking a full index scan for the value of ColumnB. Afterwards SQL Server calls Sort on the results to get them in the correct order. As inefficient as possible

B, Order C

Conclusions

It should be clear that the order of your columns in an index are very important. I've made up some guidelines for myself regarding this:

Place the most limiting columns first in an index.
By this, I mean to first determine which queries I will be running against the database, determining their frequency and then ordering the columns according to the most frequently run queries.
Place an additional index if needed
After I've ordered my columns to be as efficient as possible and see that another set of queries is run almost as frequently that they need optimization, possibly add another index on a subset of the columns in the first index. Keeping in mind for which purpose the table should be optimised (eg: SELECT vs INSERT/DELETE).

I'll be more than happy to receive some comments on possible additional tests to analyze and make my conclusions better.

Cumps.be

Modified MVC AccountController for Preview 5

Wordpress 2.6 Upgrade – Fix Missing Categories

Wordpress 2.6 Upgrade – Categories Missing

Efficient Compound Index Usage

Flickr

Twitter

Zoeken